Re: [PATCH 1/1] drivers: staging: fbtft: Hush Checkpatch.pl Error about unnecessary whitespace and comma

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Vaibhav,

[auto build test ERROR on staging/staging-testing]
[also build test ERROR on v4.11-rc4 next-20170329]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/vaibhavddit-gmail-com/drivers-staging-fbtft-Hush-Checkpatch-pl-Error-about-unnecessary-whitespace-and-comma/20170330-063109
config: x86_64-randconfig-x009-201713 (attached as .config)
compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

All errors (new ones prefixed by >>):

>> drivers/staging/fbtft/fbtft-bus.c:59:49: error: macro "define_fbtft_write_reg" requires 3 arguments, but only 2 given
    define_fbtft_write_reg(fbtft_write_reg8_bus8, u8)
                                                    ^
>> drivers/staging/fbtft/fbtft-bus.c:14:1: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'void'
    void func(struct fbtft_par *par, int len, ...)                                \
    ^
   drivers/staging/fbtft/fbtft-bus.c:60:1: note: in expansion of macro 'define_fbtft_write_reg'
    define_fbtft_write_reg(fbtft_write_reg16_bus8, u16, cpu_to_be16)
    ^~~~~~~~~~~~~~~~~~~~~~
   drivers/staging/fbtft/fbtft-bus.c:61:52: error: macro "define_fbtft_write_reg" requires 3 arguments, but only 2 given
    define_fbtft_write_reg(fbtft_write_reg16_bus16, u16)
                                                       ^
   drivers/staging/fbtft/fbtft-bus.c:63:1: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'void'
    void fbtft_write_reg8_bus9(struct fbtft_par *par, int len, ...)
    ^~~~

vim +/define_fbtft_write_reg +59 drivers/staging/fbtft/fbtft-bus.c

     8	 *
     9	 *   void (*write_reg)(struct fbtft_par *par, int len, ...);
    10	 *
    11	 *****************************************************************************/
    12	
    13	#define define_fbtft_write_reg(func, type, modifier)                          \
  > 14	void func(struct fbtft_par *par, int len, ...)                                \
    15	{                                                                             \
    16		va_list args;                                                         \
    17		int i, ret;                                                           \
    18		int offset = 0;                                                       \
    19		type *buf = (type *)par->buf;                                         \
    20										      \
    21		if (unlikely(par->debug & DEBUG_WRITE_REGISTER)) {                    \
    22			va_start(args, len);                                          \
    23			for (i = 0; i < len; i++) {                                   \
    24				buf[i] = (type)va_arg(args, unsigned int);            \
    25			}                                                             \
    26			va_end(args);                                                 \
    27			fbtft_par_dbg_hex(DEBUG_WRITE_REGISTER, par, par->info->device, type, buf, len, "%s: ", __func__);   \
    28		}                                                                     \
    29										      \
    30		va_start(args, len);                                                  \
    31										      \
    32		if (par->startbyte) {                                                 \
    33			*(u8 *)par->buf = par->startbyte;                             \
    34			buf = (type *)(par->buf + 1);                                 \
    35			offset = 1;                                                   \
    36		}                                                                     \
    37										      \
    38		*buf = modifier((type)va_arg(args, unsigned int));                    \
    39		ret = fbtft_write_buf_dc(par, par->buf, sizeof(type) + offset, 0);    \
    40		if (ret < 0)							      \
    41			goto out;						      \
    42		len--;                                                                \
    43										      \
    44		if (par->startbyte)                                                   \
    45			*(u8 *)par->buf = par->startbyte | 0x2;                       \
    46										      \
    47		if (len) {                                                            \
    48			i = len;                                                      \
    49			while (i--)						      \
    50				*buf++ = modifier((type)va_arg(args, unsigned int));  \
    51			fbtft_write_buf_dc(par, par->buf,			      \
    52					   len * (sizeof(type) + offset), 1);	      \
    53		}                                                                     \
    54	out:									      \
    55		va_end(args);                                                         \
    56	}                                                                             \
    57	EXPORT_SYMBOL(func);
    58	
  > 59	define_fbtft_write_reg(fbtft_write_reg8_bus8, u8)
    60	define_fbtft_write_reg(fbtft_write_reg16_bus8, u16, cpu_to_be16)
    61	define_fbtft_write_reg(fbtft_write_reg16_bus16, u16)
    62	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Attachment: .config.gz
Description: application/gzip

_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux