Digi claims on their website that their cards (Neo and Classic) have Linux driver support. These drivers have apparently not been tested though since 2.6 kernel. Are these drivers on their way into the kernel or out? If they are not on their way into the kernel then this patch set seems like a waste of reviewer time. The only change of substance in this series is to remove the magic number members from various structs and their associated validity checks. Otherwise series simply reduces comments, formats comments in kernel doc format, and removes unnecessary code/comments Patch 01 removes comments and migrates struct comments to kernel doc format in header files. Patch 02 cleans the preprocessor header guards. Patch 03 cleans up comments in source files, removes unnecessary comments, reduces function comments on functions with internal linkage, migrates to kernel doc format function comments on functions with external linkage. Patch 04 removes struct magic number members and validity checks. Patch 05 removes dead code, guarded by preprocessor '#if 1' Patch 06 cleans the TODO file Code is untested. Builds on x86_64 and PowerPC. Tobin C. Harding (6): staging: dgnc: clean up header comments staging: dgnc: remove double underscore staging: dgnc: remove unnecessary comments staging: dgnc: remove struct member magic numbers staging: dgnc: remove dead code staging: dgnc: remove error message task drivers/staging/dgnc/TODO | 2 - drivers/staging/dgnc/dgnc_cls.c | 148 ++++----------- drivers/staging/dgnc/dgnc_cls.h | 42 ++--- drivers/staging/dgnc/dgnc_driver.c | 88 +-------- drivers/staging/dgnc/dgnc_driver.h | 340 +++++++++++++++++++-------------- drivers/staging/dgnc/dgnc_mgmt.c | 31 +--- drivers/staging/dgnc/dgnc_mgmt.h | 7 +- drivers/staging/dgnc/dgnc_neo.c | 228 +++++------------------ drivers/staging/dgnc/dgnc_neo.h | 85 +++++---- drivers/staging/dgnc/dgnc_pci.h | 13 +- drivers/staging/dgnc/dgnc_tty.c | 371 +++++++++++-------------------------- drivers/staging/dgnc/dgnc_tty.h | 6 +- drivers/staging/dgnc/dgnc_utils.c | 9 +- drivers/staging/dgnc/dgnc_utils.h | 6 +- drivers/staging/dgnc/digi.h | 134 +++++++++----- 15 files changed, 585 insertions(+), 925 deletions(-) -- 2.7.4 _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
