On Mon, Mar 27, 2017 at 5:12 PM, <vaibhavddit@xxxxxxxxx> wrote:
> From: Vaibhav Kothari <vaibhavddit@xxxxxxxxx>
"From: .." should not be included in the patch. The subject is still
incorrect, there should be a space after each colon. The subject
should give overview of changes made in the patch.
It is preferred to fix single checkpatch issue in a patch.
> - Fixing up check-patch error & Warnings
> - Added blank line between declaration and defination
> at various places
The commit message is not proper. There are no full stops at the
end of any sentence. Also change defination to definition.
Check git log for example.
static int gc2235_read_reg(struct i2c_client *client,
> return -EINVAL;
> }
>
> - memset(msg, 0 , sizeof(msg));
> + memset(msg, 0, sizeof(msg));
This change is not reflected in commit message.
> if (is_init == 0) {
> /* force gc2235 to do a reset in res change, otherwise it
> - * can not output normal after switching res. and it is not
> - * necessary for first time run up after power on, for the sack
> - * of performance
> - */
> + * can not output normal after switching res. and it is not
> + * necessary for first time run up after power on, for the sack
> + * of performance
> + */
Even this change fixes a different issue.
Send patch for a single checkpatch issue.
https://kernelnewbies.org/FirstKernelPatch#submit%2Ba%2Bpatch
Check the First Kernel Patch page.
Thanks,
Varsha Rao
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
