Checkpatch emits various warnings/checks when parsing ks_hostif.c. A number of these relate to the implementation of Michael MIC. This patch set cleans up code around the function calls using Michael MIC, including the whole of the function hostif_data_request(). Driver uses a custom implementation of the Miachale MIC algorithm. The kernel already has an implementation, eventually we should be using the kernel implementation. As a first step, let's clean up the code around the calls to Michael MIC so that it is easier to switch implementations later on. Patch 01 simplifies a complex logical statement. Patch 02 removes one [unnecessary] instance of camel case without touching the Michael MIC implementation. Patch 03 adds an item to the TODO file. Patch 04 renames an identifier to be more typical of the kernel. The following patches clean up hostif_data_request(). Patch 05 fixes logical continuation warnings. Patch 06 fixes multiple line dereference warnings. Patch 07 fixes a Smatch warning, null check after dereference. Patches 08 through 10 replace magic numbers. Patch 11 cleans up comments. Patch 12 adds an intermediate variable to replace arithmetic expressions as function argument. Code is build tested only (x86_64 and PowerPC). Tobin C. Harding (12): staging: ks7010: simplify complex logical statment staging: ks7010: rename RecvMIC to recv_mic staging: ks7010: add item to TODO file staging: ks7010: rename identifier packet to skb staging: ks7010: fix checkpatch LOGICAL_CONTINUATIONS staging: ks7010: fix checkpatch MULTILINE_DEREFERENCE staging: ks7010: move null check before dereference staging: ks7010: replace magic number 8 staging: ks7010: replace magic number 6 staging: ks7010: replace magic number 12 staging: ks7010: clean up comments staging: ks7010: add intermediate variable drivers/staging/ks7010/TODO | 2 + drivers/staging/ks7010/ks_hostif.c | 142 ++++++++++++++++++----------------- drivers/staging/ks7010/ks_hostif.h | 2 +- drivers/staging/ks7010/michael_mic.h | 2 + 4 files changed, 78 insertions(+), 70 deletions(-) -- 2.7.4 _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
