On Thu, Mar 23, 2017 at 04:38:38AM -0400, Mark Stenglein wrote: > Fixes three instances of the following checklist error: > - ERROR: Macros with complex values should be enclosed > in parentheses > > Simply adds parentheses around the macros to fix the problem. > > Signed-off-by: Mark Stenglein <mark@xxxxxxxxxx> > --- > drivers/staging/most/mostcore/core.c | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/drivers/staging/most/mostcore/core.c b/drivers/staging/most/mostcore/core.c > index 191404bc5906..13e65f149d68 100644 > --- a/drivers/staging/most/mostcore/core.c > +++ b/drivers/staging/most/mostcore/core.c > @@ -341,8 +341,8 @@ static ssize_t show_channel_starving(struct most_c_obj *c, > return snprintf(buf, PAGE_SIZE, "%d\n", c->is_starving); > } > > -#define create_show_channel_attribute(val) \ > - static MOST_CHNL_ATTR(val, 0444, show_##val, NULL) > +#define(create_show_channel_attribute(val) \ > + static MOST_CHNL_ATTR(val, 0444, show_##val, NULL)) I don't think this does what you think it does. Did you test build this??? Please learn C before working on kernel code, the kernel is not a place to learn it. thanks, greg k-h _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
