Comparison, does not equal zero, is redundant 'if (foo != 0)' is equal to 'if (foo)' Typical kernel coding style is to use the shorter form. Remove unnecessary non-zero comparison. Signed-off-by: Tobin C. Harding <me@xxxxxxxx> --- drivers/staging/ks7010/ks7010_sdio.c | 4 ++-- drivers/staging/ks7010/ks_hostif.c | 6 +++--- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/ks7010/ks7010_sdio.c b/drivers/staging/ks7010/ks7010_sdio.c index 40ec028..8823e93 100644 --- a/drivers/staging/ks7010/ks7010_sdio.c +++ b/drivers/staging/ks7010/ks7010_sdio.c @@ -61,7 +61,7 @@ static int ks7010_sdio_read(struct ks_wlan_private *priv, unsigned int address, else /* CMD53 multi-block transfer */ rc = sdio_memcpy_fromio(card->func, buffer, address, length); - if (rc != 0) + if (rc) DPRINTK(1, "sdio error=%d size=%d\n", rc, length); return rc; @@ -80,7 +80,7 @@ static int ks7010_sdio_write(struct ks_wlan_private *priv, unsigned int address, else /* CMD53 */ rc = sdio_memcpy_toio(card->func, address, buffer, length); - if (rc != 0) + if (rc) DPRINTK(1, "sdio error=%d size=%d\n", rc, length); return rc; diff --git a/drivers/staging/ks7010/ks_hostif.c b/drivers/staging/ks7010/ks_hostif.c index 3eb0f2e..83cda1f 100644 --- a/drivers/staging/ks7010/ks_hostif.c +++ b/drivers/staging/ks7010/ks_hostif.c @@ -528,7 +528,7 @@ void hostif_mib_get_confirm(struct ks_wlan_private *priv) mib_val_size = get_WORD(priv); /* MIB value size */ mib_val_type = get_WORD(priv); /* MIB value type */ - if (mib_status != 0) { + if (mib_status) { /* in case of error */ DPRINTK(1, "attribute=%08X, status=%08X\n", mib_attribute, mib_status); @@ -604,7 +604,7 @@ void hostif_mib_set_confirm(struct ks_wlan_private *priv) mib_status = get_DWORD(priv); /* MIB Status */ mib_attribute = get_DWORD(priv); /* MIB attribute */ - if (mib_status != 0) { + if (mib_status) { /* in case of error */ DPRINTK(1, "error :: attribute=%08X, status=%08X\n", mib_attribute, mib_status); @@ -834,7 +834,7 @@ void hostif_scan_indication(struct ks_wlan_private *priv) DPRINTK(3, "scan_ind_count = %d\n", priv->scan_ind_count); ap_info = (struct ap_info_t *)(priv->rxp); - if (priv->scan_ind_count != 0) { + if (priv->scan_ind_count) { for (i = 0; i < priv->aplist.size; i++) { /* bssid check */ if (!memcmp (ap_info->bssid, -- 2.7.4 _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel