Re: [PATCH 0/5] staging: vc04_services: camera driver maintance

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Mar 20, 2017 at 07:53:18AM -0700, Michael Zoran wrote:
> On Mon, 2017-03-20 at 16:57 +0300, Dan Carpenter wrote:
> > On Mon, Mar 20, 2017 at 04:06:00AM -0700, Michael Zoran wrote:
> > > On Mon, 2017-03-20 at 13:55 +0300, Dan Carpenter wrote:
> > > > I'm not going to review this because it has kbuild errors.
> > > > 
> > > > regards,
> > > > dan carpenter
> > > > 
> > > 
> > > Hi, can you e-mail out the errors or send them to me.  It worked
> > > when
> > > I submitted it.
> > > 
> > 
> > The problem is that you added a function only for ARM but the camera
> > can build on i386.
> > 
> > Anyway, we need to figure out why you aren't getting the kbuild
> > emails
> > and fix that.  I forwarded the first email to you.  The other is
> > basically the same.
> > 
> > regards,
> > dan carpenter
> > 
> 
> OK, thanks for sending it to me.
> 
> I don't quite understand how that is possible in all since the whole
> subtree depends on RASPBERRYPI_FIRMWARE which I had nothing to do with
> setting up.  Sounds to me like the real issue here is that the
> RASPBERRYPI_FIRMARE driver wasn't setup correctly in the first place.

It depends RASPBERRYPI_FIRMARE or COMPILE_TEST.  The kbuild bot has
COMPILE_TEST enabled so that solves the mystery of why the build failed.

> I also noticed when I was trying to understand how the raspberrypi
> driver works in the first place in that it doesn't always dump the
> firmware revision correctly if the DT node mbox handle gets pointed to
> who knows where.
> 
> I've been complaining about very selective e-mails on so called public
> e-mail lists for a very long time now, and nobody has done anything
> about it.

I have no idea what your talking about but I try to forget emails right
away so that I'll be able to answer honestly that, "I don't recall" in
case I am ever asked to testify in front of the United States senate.

> Sometimes I don't get any e-mail for a week and then I'll get
> a flood of e-mail thats 2 weeks old.  And who knows which e-mails lists
> changes are going to.

This business with multiple lists *is* very annoying.  Patches to do
with kernel code should be sent to driver-devel.

regards,
dan carpenter


_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel




[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux