Re: [PATCH 1/6] bcm2835-gpio-exp: Driver for GPIO expander via mailbox service

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, Mar 18, 2017 at 09:42:43PM -0700, Michael Zoran wrote:
> On Sat, 2017-03-18 at 14:23 +0100, Stefan Wahren wrote:
> > > Michael Zoran <mzoran@xxxxxxxxxxxx> hat am 17. März 2017 um 16:22
> > > geschrieben:
> > > 
> > > 
> > > From: Dave Stevenson <dave.stevenson@xxxxxxxxxxxxxxx>
> > > 
> > > Pi3 and Compute Module 3 have a GPIO expander that the
> > > VPU communicates with.
> > > There is a mailbox service that now allows control of this
> > > expander, so add a kernel driver that can make use of it.
> > > 
> > > Pwr_led node added to device-tree for Pi3.
> > 
> > Looks like debris
> > 
> > > 
> > > Signed-off-by: Dave Stevenson <dave.stevenson@xxxxxxxxxxxxxxx>
> > > 
> > > Stripped off changes to Makefile and Kconfig
> > > Also stripped off changes to raspberrypi-firmware.h
> > > Moved to drivers/staging/vc04_services/bcm2835-firmware-gpio
> > > 
> > > Signed-off-by: Michael Zoran <mzoran@xxxxxxxxxxxx>
> > > ---
> > > 
> 
> Hi Stefan,
> 
> For this particular patch, I simply cherry-picked the orignal version
> of the driver in the github directory.  It's a 100% original copy of
> the initial version.
> 
> So any grips/complaints should be sent to dave.stevenson@xxxxxxxxxxxxxxx.

Nah.  Fix all the things Stefan mentioned and resend.  Just mention in
the changelog that you made a few changes yourself from Dave's original.

regards,
dan carpenter

_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel




[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux