On Sun, 19 Mar 2017, Arushi Singhal wrote: > Moved logical AND operator to previous line to fix the following > checkpatch issue: You seem to have AND and OR confused. AND is &&, OR is ||. This patch is about OR, not AND. julia > > CHECK: Logical continuations should be on the previous line. > > Signed-off-by: Arushi Singhal <arushisinghal19971997@xxxxxxxxx> > --- > drivers/staging/speakup/main.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/staging/speakup/main.c b/drivers/staging/speakup/main.c > index c10445624e92..def1a36da9dd 100644 > --- a/drivers/staging/speakup/main.c > +++ b/drivers/staging/speakup/main.c > @@ -2173,10 +2173,10 @@ speakup_key(struct vc_data *vc, int shift_state, int keycode, u_short keysym, > if (up_flag || spk_killed || type == KT_SHIFT) > goto out; > spk_shut_up &= 0xfe; > - kh = (value == KVAL(K_DOWN)) > - || (value == KVAL(K_UP)) > - || (value == KVAL(K_LEFT)) > - || (value == KVAL(K_RIGHT)); > + kh = (value == KVAL(K_DOWN)) || > + (value == KVAL(K_UP)) || > + (value == KVAL(K_LEFT)) || > + (value == KVAL(K_RIGHT)); > if ((cursor_track != read_all_mode) || !kh) > if (!spk_no_intr) > spk_do_flush(); > -- > 2.11.0 > > -- > You received this message because you are subscribed to the Google Groups "outreachy-kernel" group. > To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@xxxxxxxxxxxxxxxx. > To post to this group, send email to outreachy-kernel@xxxxxxxxxxxxxxxx. > To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20170319072403.10354-2-arushisinghal19971997%40gmail.com. > For more options, visit https://groups.google.com/d/optout. > _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel