> Michael Zoran <mzoran@xxxxxxxxxxxx> hat am 17. März 2017 um 16:22 geschrieben: > > > The original change this driver is based on adds the needed mailbox > defines to include/soc/bcm2835/raspberrypi-firmware.h. That is not > appropriate at this time, so add the defines directly into the > driver source. > > This change is based on: > https://github.com/raspberrypi/linux > > Branch: rpi-4.11.y(commit efad03c3c86642dafccc03fcdd3ab84dd11e2ab7) > > Signed-off-by: Michael Zoran <mzoran@xxxxxxxxxxxx> > --- > drivers/staging/vc04_services/bcm2835-firmware-gpio/gpio-bcm-exp.c | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/drivers/staging/vc04_services/bcm2835-firmware-gpio/gpio-bcm-exp.c b/drivers/staging/vc04_services/bcm2835-firmware-gpio/gpio-bcm-exp.c > index 681a91492d4c..ba9750107957 100644 > --- a/drivers/staging/vc04_services/bcm2835-firmware-gpio/gpio-bcm-exp.c > +++ b/drivers/staging/vc04_services/bcm2835-firmware-gpio/gpio-bcm-exp.c > @@ -43,6 +43,13 @@ struct gpio_get_set_state { > u32 gpio, state; > }; > > +enum rpi_firmware_gpio_property_tag { > + RPI_FIRMWARE_GET_GPIO_STATE = 0x00030041, > + RPI_FIRMWARE_SET_GPIO_STATE = 0x00038041, > + RPI_FIRMWARE_GET_GPIO_CONFIG = 0x00030043, > + RPI_FIRMWARE_SET_GPIO_CONFIG = 0x00038043, > +}; > + As i point out before, please fold into the first patch so we don't break the build. Btw a TODO comment to move this into include/soc/bcm2835/raspberrypi-firmware.h later would be nice. > static int brcmexp_gpio_get_polarity(struct gpio_chip *gc, unsigned int off) > { > struct brcmexp_gpio *gpio; > -- > 2.11.0 > _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
