Re: [PATCH 5/6] staging: media: atomisp: fill properly hmm_bo_type_strings when ION is disabled

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 16 Mar 2017 17:51:06 +0000
Alan Cox <alan@xxxxxxxxxxxxxxx> wrote:

> On Wed, 2017-03-15 at 14:09 -0400, Jérémy Lefaure wrote:
> > When CONFIG_ION is disabled, HMM_BO_LAST is 3. In this case, "i"
> > should
> > not be added in hmm_bo_type_strings.  
> 
> No the goal is to remove ifdefs - that's not the way to go with driver
> clean up. Instead the array size should always cover the four strings.
> 
Mmh, ok I understand. So I guess that the fix should have been to
remove the ifdef in hmm_bo.h. At first glance this should be ok even if
HMM_BO_LAST is used for the loop limit in bo_show.

Greg, this patch is already in staging-next. Should I send a patch that
reverts that change (maybe a patch that removes both ifdef if it is
really ok) or will you discard it ? Sorry, I don't know how you manage
this branch.

Thanks,
Jérémy
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel




[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux