On Wed, Mar 15, 2017 at 03:21:52PM +0530, sunil.m@xxxxxxxxxxxx wrote: > From: Suniel Mahesh <sunil.m@xxxxxxxxxxxx> > > Fixed the following checkpatch.pl warning: > Possible unnecessary 'out of memory' message > > Signed-off-by: Suniel Mahesh <sunil.m@xxxxxxxxxxxx> > --- > Changes for v3: > > - Split earlier patches into multiple commits for easy review > as suggested by Greg K-H > - Modified subject and description for better readability > - Rebased on top of next-20170310 > - Patches were tested and built on next-20170310 and staging-testing > as suggested by Greg K-H, no errors reported > > Changes for v2: > > - Improve error handling reported by checkpatch.pl in rtl_core.c > - new patch addition to the series > - Rebased on top of next-20170306 > --- > drivers/staging/rtl8192e/rtl8192e/rtl_core.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_core.c b/drivers/staging/rtl8192e/rtl8192e/rtl_core.c > index eb2321c..37a03ca 100644 > --- a/drivers/staging/rtl8192e/rtl8192e/rtl_core.c > +++ b/drivers/staging/rtl8192e/rtl8192e/rtl_core.c > @@ -971,8 +971,8 @@ static void _rtl92e_init_priv_variable(struct net_device *dev) > > priv->pFirmware = vzalloc(sizeof(struct rt_firmware)); > if (!priv->pFirmware) > - netdev_err(dev, > - "rtl8192e: Unable to allocate space for firmware\n"); > + return; The patch description doesn't mention this return. regards, dan carpenter _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
