On Mon, Mar 13, 2017 at 03:11:10PM +0300, Dan Carpenter wrote: > On Sun, Mar 12, 2017 at 02:37:22PM +0100, Greg KH wrote: > > On Sat, Mar 11, 2017 at 01:07:40PM +0000, Craig Inches wrote: > > > This patch resolves the "Comparisons should place the constant on > > > the right side of the test" found with checkpatch tool. > > > > Both are constants, I think checkpatch is the thing that is wrong here, > > don't you agree? > > Sort of constant-ish... The sizeof(*value) changes each time the macro > is used. I feel like checkpatch is right. > > regads, > dan carpenter > That was my take aswell.. PAGE_SIZE is constant for each boot, but sizeof could change. Happy to be lead by the more experienced here though. Cheers Craig _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
