Replace strcpy with strlcpy as strcpy does not check for buffer overflow. This is found using Flawfinder. Signed-off-by: simran singhal <singhalsimran0@xxxxxxxxx> --- v2: -Correcting the place of the parenthesis drivers/staging/android/ashmem.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/android/ashmem.c b/drivers/staging/android/ashmem.c index 7cbad0d..eb2f4ef 100644 --- a/drivers/staging/android/ashmem.c +++ b/drivers/staging/android/ashmem.c @@ -548,7 +548,8 @@ static int set_name(struct ashmem_area *asma, void __user *name) if (unlikely(asma->file)) ret = -EINVAL; else - strcpy(asma->name + ASHMEM_NAME_PREFIX_LEN, local_name); + strlcpy(asma->name + ASHMEM_NAME_PREFIX_LEN, local_name, + sizeof(asma->name + ASHMEM_NAME_PREFIX_LEN)); mutex_unlock(&ashmem_mutex); return ret; -- 2.7.4 _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
