Re: [PATCH] Staging: fbtft: fbtft-bus.c: checkpatch error

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Mar 09, 2017 at 12:59:57AM +0530, Manoj Sawai wrote:
> Fixes a checkpatch error.
> 
> "ERROR: space prohibited before that close parenthesis ')'"
> 
> Signed-off-by: Manoj Sawai <mas@xxxxxxxxxxxx>
> ---
>  drivers/staging/fbtft/fbtft-bus.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/fbtft/fbtft-bus.c b/drivers/staging/fbtft/fbtft-bus.c
> index ec45043c0830..34a7f3aa2c2e 100644
> --- a/drivers/staging/fbtft/fbtft-bus.c
> +++ b/drivers/staging/fbtft/fbtft-bus.c
> @@ -68,9 +68,9 @@ void func(struct fbtft_par *par, int len, ...)                                \
>  }                                                                             \
>  EXPORT_SYMBOL(func);
>  
> -define_fbtft_write_reg(fbtft_write_reg8_bus8, u8, )
> +define_fbtft_write_reg(fbtft_write_reg8_bus8, u8)

Why did you modify this file to break the build???

This doesn't fix anything, you must ALWAYS test build your changes
otherwise you end up with a very grumpy maintainer who knows you didn't
even take the basic time to test your modification.

greg k-h
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel



[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux