Re: [PATCH] staging: comedi: cb_pcidas64: move loop invariant

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Mar 07, 2017 at 08:03:16PM +0100, Greg Kroah-Hartman wrote:
> On Tue, Mar 07, 2017 at 01:29:35PM +1100, Tobin C. Harding wrote:
> > Loop invariant is inside the loop so code checks invariant on each
> > iteration of the loop. Invariant can be moved outside of the loop so
> > it is only checked once.
> > 
> > Move loop invariant outside of for loop.
> 
> But does it really matter?  Does this fix an issue?  Make something
> faster in a _measurable_ way?  Did you test this on the hardware?

Good points, patch is untested and does not fix a particular
issue. Lesson learned.

thanks,
Tobin.
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel



[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux