On Sat, Mar 4, 2017 at 9:22 PM, Joe Perches <joe@xxxxxxxxxxx> wrote: > On Sat, 2017-03-04 at 21:00 +0530, simran singhal wrote: >> This patch-series removes unnecessary cast on void pointer in various >> drivers. > > Much better, thanks. > > Trivia: (and it's probably not necessary to resend) > > The cover letter should describe the subsystem being > changed or ideally something like "treewide" if the > series touches files throughout the kernel sources. > > So this cover letter ideally would have a subject like: > > Subject: [PATCH v5 0/5] staging: Remove unnecessary casts of void pointer > >> v5: >> -Fixed compliation warning in lustre/lustre/llite/range_lock.c >> which remain unfixed in v3. >> v4: >> -change the cover-letter subject >> v3: >> -Fixed compilation warning in lustre/lustre/llite/range_lock.c >> >> simran singhal (5): >> staging: nvec: Remove unnecessary cast on void pointer >> staging: lustre: Remove unnecessary cast on void pointer >> staging: lustre: lustre: Remove unnecessary cast on void pointer >> staging: rts5208: Remove unnecessary cast on void pointer >> staging: rtl8712: Remove unnecessary cast on void pointer > > Some of these are acting on multiple instances. > > Please try to use plural and singular descriptions > where appropriate. > Thanks Joe, Will keep this in mind from next time. >> drivers/staging/lustre/lustre/llite/range_lock.c | 2 +- >> drivers/staging/lustre/lustre/lmv/lmv_obd.c | 4 ++-- >> drivers/staging/nvec/nvec_kbd.c | 2 +- >> drivers/staging/rtl8712/rtl8712_recv.c | 11 +++++------ >> drivers/staging/rts5208/rtsx_transport.c | 3 +-- >> 5 files changed, 10 insertions(+), 12 deletions(-) > _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
