> Sergiy Redko <sergredko@xxxxxxxxx> hat am 4. März 2017 um 06:15 geschrieben:
>
>
> On 03/03, Stefan Wahren wrote:
> > Hi Sergiy,
> >
> > Am 03.03.2017 um 09:05 schrieb Sergiy Redko:
> > > fix coding style: move brace to the line above
> >
> > please make the subject of your patch more distinct. We get a lot of
> > coding style fixes for vchiq.
> >
> > Btw it looks you missed to add Greg as staging maintainer.
> >
> > >
> > > Signed-off-by: Sergiy Redko <sergredko@xxxxxxxxx>
> > > ---
> > > drivers/staging/vc04_services/interface/vchiq_arm/vchiq_shim.c | 3 +--
> > > 1 file changed, 1 insertion(+), 2 deletions(-)
> > >
> > > diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_shim.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_shim.c
> > > index 48984abc3854..ca896a518e15 100644
> > > --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_shim.c
> > > +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_shim.c
> > > @@ -797,8 +797,7 @@ int32_t vchi_get_peer_version(const VCHI_SERVICE_HANDLE_T handle, short *peer_ve
> > > {
> > > int32_t ret = -1;
> > > SHIM_SERVICE_T *service = (SHIM_SERVICE_T *)handle;
> > > - if (service)
> > > - {
> > > + if (service) {
> >
> > Since you want to fix coding stlye i think it's better to leave an empty
> > line between the declaration and the if statement.
> >
> > Stefan
> >
> > > VCHIQ_STATUS_T status;
> > >
> > > status = vchiq_get_peer_version(service->handle, peer_version);
> >
> >
> Hi Stefan,
>
> Thanks for the feedback.
>
> I'm not sure what to do next.
> I'm guessing I should update my patch with your suggestion and
> resubmit it with Greg in CC.
Yes
>
> Should I send it as next message in this thread or start a new
> thread with a better subject.
Please start a new thread for V2 of your patch and don't forget the changelog.
Thanks
>
> Sergiy
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
