On Fri, 2017-03-03 at 21:35 +0530, SIMRAN SINGHAL wrote: > On Fri, Mar 3, 2017 at 9:20 PM, Joe Perches <joe@xxxxxxxxxxx> wrote: > > On Fri, 2017-03-03 at 17:05 +0530, simran singhal wrote: > > > Fixed compilation warning in lustre/lustre/llite/range_lock.c > > > > Really? What compilation warning was removed? > > CC [M] drivers/staging/lustre/lustre/mgc/mgc_request.o > drivers/staging/lustre/lustre/mgc/mgc_request.c: In function > ‘mgc_set_info_async’: > drivers/staging/lustre/lustre/mgc/mgc_request.c:1036:115: warning: > format ‘%s’ expects argument of type ‘char *’, but argument 3 has type > ‘void *’ [-Wformat=] > > I was getting this warning because of changing (char *)val to val > where val is a pointer to void. > So I fixed this by reverting this change. Wrong thought. Your original defective patches were not applied and this is a simple revision to those defective patches that do not include defects. As Julia has said, you should use the imperative and describe the change that this patch series implements. i.e: Subject: [PATCH V3 0/5] staging: Remove unnecessary casts Casting void pointers to another undereferenced type is generally unnecessary so remove the unnecessary casts. _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
