On Fri, 3 Mar 2017, SIMRAN SINGHAL wrote:
> On Fri, Mar 3, 2017 at 9:20 PM, Joe Perches <joe@xxxxxxxxxxx> wrote:
> > On Fri, 2017-03-03 at 17:05 +0530, simran singhal wrote:
> >> Fixed compilation warning in lustre/lustre/llite/range_lock.c
> >
> > Really? What compilation warning was removed?
>
> CC [M] drivers/staging/lustre/lustre/mgc/mgc_request.o
> drivers/staging/lustre/lustre/mgc/mgc_request.c: In function
> ‘mgc_set_info_async’:
> drivers/staging/lustre/lustre/mgc/mgc_request.c:1036:115: warning:
> format ‘%s’ expects argument of type ‘char *’, but argument 3 has type
> ‘void *’ [-Wformat=]
>
> I was getting this warning because of changing (char *)val to val
> where val is a pointer to void.
> So I fixed this by reverting this change.
Someone pointed out recently that when you make the cover letter for vn+1,
the subject should not change. It doesn't describe what is new in the
version. You put that in the message.
julia
>
> Simran
>
> >
> >> simran singhal (5):
> >> staging: nvec: Remove unnecessary cast on void pointer
> >> staging: lustre: Remove unnecessary cast on void pointer
> >> staging: lustre: lustre: Remove unnecessary cast on void pointer
> >> staging: rts5208: Remove unnecessary cast on void pointer
> >> staging: rtl8712: Remove unnecessary cast on void pointer
> >
> > What compiler warns about unnecessary casts?
> >
> >> drivers/staging/lustre/lustre/llite/range_lock.c | 2 +-
> >> drivers/staging/lustre/lustre/lmv/lmv_obd.c | 4 ++--
> >> drivers/staging/lustre/lustre/mgc/mgc_request.c | 2 +-
> >> drivers/staging/nvec/nvec_kbd.c | 2 +-
> >> drivers/staging/rtl8712/rtl8712_recv.c | 11 +++++------
> >> drivers/staging/rts5208/rtsx_transport.c | 3 +--
> >> 6 files changed, 11 insertions(+), 13 deletions(-)
> >>
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@xxxxxxxxxxxxxxxx.
> To post to this group, send email to outreachy-kernel@xxxxxxxxxxxxxxxx.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/CALrZqyMKJvhQMAdjtLWWKTtxOP%2BicRZ6bctB0bTtzA8gJi%2BwNA%40mail.gmail.com.
> For more options, visit https://groups.google.com/d/optout.
>
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
