Re: [PATCH 3/5] staging: lustre: lustre: Remove unnecessary cast on void pointer

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 2017-03-03 at 02:49 +0530, simran singhal wrote:
> The following Coccinelle script was used to detect this:
> @r@
> expression x;
> void* e;
> type T;
> identifier f;
> @@
> (
>   *((T *)e)
> > 
> 
>   ((T *)x)[...]
> > 
> 
>   ((T*)x)->f
> > 
> 
> - (T*)
>   e
> )

NAK.

Nice, but you still have to verify correctness
before submitting these patches.

> diff --git a/drivers/staging/lustre/lustre/mgc/mgc_request.c b/drivers/staging/lustre/lustre/mgc/mgc_request.c
[]
> @@ -1034,7 +1034,7 @@ static int mgc_set_info_async(const struct lu_env *env, struct obd_export *exp,
>  		rc = sptlrpc_parse_flavor(val, &flvr);
>  		if (rc) {
>  			CERROR("invalid sptlrpc flavor %s to MGS\n",
> -			       (char *)val);
> +			       val);

Try compiling this.

_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel



[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux