On Tue, 2017-02-28 at 06:51 +0100, Greg Kroah-Hartman wrote: > On Tue, Feb 28, 2017 at 10:35:30AM +0530, Arushi Singhal wrote: > > Error reported by checkpatch.pl as "avoid multiple line dereference". > > Addition of new variables to make the code more readable and also to > > correct about mentioned error as by itroducing new variables line is > > not exceeding 80 characters. [] > Remember, coding style cleanups are to be done to make the code easier > to understand and follow. Not to blindly follow a perl script that > can not think. Sometimes it is not right... Yeah, what Greg said. Also very long identifier names like RefreshRateTableIndex and simple dereferences like XGI330_RefIndex[RefreshRateTableIndex + (*i)].Ext_InfoFlag make using 80 columns silly. Just ignore 80 column limits when there are 20+ character identifiers. Ideally shorten the identifiers to something less verbose and/or use temporaries where appropriate like I showed in my reply to your suggested V5 patch. _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
