Function contains code at differing levels of abstraction. This is shown by the fact that conditional is loop-invariant. Code may be refactored out into a separate function. Once refactored into separate function a number of minor code style fixes may be implemented. Remove multi-line dereferece, fix function parameter alignment. This is a re-work of patch (and based of review of); [PATCH] staging: comedi: db_pcidas64: invert conditional However the subject was incorrect, hence a *new* patch series. Tobin C. Harding (2): staging: comedi: cb_pcidas64: refactor out function staging: comedi: cb_pcidas64: refactor relocated code drivers/staging/comedi/drivers/cb_pcidas64.c | 27 +++++++++++++++++++-------- 1 file changed, 19 insertions(+), 8 deletions(-) -- 2.7.4 _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
