On Sun, 26 Feb 2017, Arushi Singhal wrote:
> Unnecessary parentheses are removed as reported by checkpatch.pl
> to make coder nicer and to improve readability.
> Also coding style is improved.For example:-
> It's often nicer to read if &(foo[0]) is converted to foo like:
> memcpy(&(ap->bssid[0]), &(ap_info->bssid[0]), ETH_ALEN);
> memcpy(ap->bssid, ap_info->bssid, ETH_ALEN);
Something is wrong in this patch. It looks like it is introducing the
code that you wanted to remove.
In the commit message, there should be a space after the period. It is
not clear what "For example:-" means. If it is part of the same sentence
as the next line, then tIts in the next line should not be capitalized.
Did Greg not accept the previous version of this patch?
julia
>
> Signed-off-by: Arushi Singhal <arushisinghal19971997@xxxxxxxxx>
> ---
> Changes in v4:
> - Commit message made more accurate and as per the changes.
>
> drivers/staging/ks7010/ks_hostif.c | 24 ++++++++++++------------
> 1 file changed, 12 insertions(+), 12 deletions(-)
>
> diff --git a/drivers/staging/ks7010/ks_hostif.c b/drivers/staging/ks7010/ks_hostif.c
> index b643a37fb943..1fbd495e5e63 100644
> --- a/drivers/staging/ks7010/ks_hostif.c
> +++ b/drivers/staging/ks7010/ks_hostif.c
> @@ -113,7 +113,7 @@ int get_current_ap(struct ks_wlan_private *priv, struct link_ap_info_t *ap_info)
> int rc = 0;
>
> DPRINTK(3, "\n");
> - ap = &priv->current_ap;
> + ap = &(priv->current_ap);
>
> if ((priv->connect_status & CONNECT_STATUS_MASK) == DISCONNECT_STATUS) {
> memset(ap, 0, sizeof(struct local_ap_t));
> @@ -121,19 +121,19 @@ int get_current_ap(struct ks_wlan_private *priv, struct link_ap_info_t *ap_info)
> }
>
> /* bssid */
> - memcpy(ap->bssid, ap_info->bssid, ETH_ALEN);
> + memcpy(&(ap->bssid[0]), &(ap_info->bssid[0]), ETH_ALEN);
> /* essid */
> - memcpy(ap->ssid.body, priv->reg.ssid.body,
> + memcpy(&(ap->ssid.body[0]), &(priv->reg.ssid.body[0]),
> priv->reg.ssid.size);
> ap->ssid.size = priv->reg.ssid.size;
> /* rate_set */
> - memcpy(ap->rate_set.body, ap_info->rate_set.body,
> + memcpy(&(ap->rate_set.body[0]), &(ap_info->rate_set.body[0]),
> ap_info->rate_set.size);
> ap->rate_set.size = ap_info->rate_set.size;
> if (ap_info->ext_rate_set.size) {
> /* rate_set */
> - memcpy(&ap->rate_set.body[ap->rate_set.size],
> - ap_info->ext_rate_set.body,
> + memcpy(&(ap->rate_set.body[ap->rate_set.size]),
> + &(ap_info->ext_rate_set.body[0]),
> ap_info->ext_rate_set.size);
> ap->rate_set.size += ap_info->ext_rate_set.size;
> }
> @@ -153,11 +153,11 @@ int get_current_ap(struct ks_wlan_private *priv, struct link_ap_info_t *ap_info)
> ap->rsn_ie.id = 0x30;
> if (ap_info->rsn.size <= RSN_IE_BODY_MAX) {
> ap->rsn_ie.size = ap_info->rsn.size;
> - memcpy(ap->rsn_ie.body, ap_info->rsn.body,
> + memcpy(&(ap->rsn_ie.body[0]), &(ap_info->rsn.body[0]),
> ap_info->rsn.size);
> } else {
> ap->rsn_ie.size = RSN_IE_BODY_MAX;
> - memcpy(ap->rsn_ie.body, ap_info->rsn.body,
> + memcpy(&(ap->rsn_ie.body[0]), &(ap_info->rsn.body[0]),
> RSN_IE_BODY_MAX);
> }
> } else if ((ap_info->rsn_mode & RSN_MODE_WPA)
> @@ -165,11 +165,11 @@ int get_current_ap(struct ks_wlan_private *priv, struct link_ap_info_t *ap_info)
> ap->wpa_ie.id = 0xdd;
> if (ap_info->rsn.size <= RSN_IE_BODY_MAX) {
> ap->wpa_ie.size = ap_info->rsn.size;
> - memcpy(ap->wpa_ie.body, ap_info->rsn.body,
> + memcpy(&(ap->wpa_ie.body[0]), &(ap_info->rsn.body[0]),
> ap_info->rsn.size);
> } else {
> ap->wpa_ie.size = RSN_IE_BODY_MAX;
> - memcpy(ap->wpa_ie.body, ap_info->rsn.body,
> + memcpy(&(ap->wpa_ie.body[0]), &(ap_info->rsn.body[0]),
> RSN_IE_BODY_MAX);
> }
> } else {
> @@ -212,7 +212,7 @@ int get_ap_information(struct ks_wlan_private *priv, struct ap_info_t *ap_info,
> memset(ap, 0, sizeof(struct local_ap_t));
>
> /* bssid */
> - memcpy(ap->bssid, ap_info->bssid, ETH_ALEN);
> + memcpy(&(ap->bssid[0]), &(ap_info->bssid[0]), ETH_ALEN);
> /* rssi */
> ap->rssi = ap_info->rssi;
> /* sq */
> @@ -224,7 +224,7 @@ int get_ap_information(struct ks_wlan_private *priv, struct ap_info_t *ap_info,
> /* channel */
> ap->channel = ap_info->ch_info;
>
> - bp = ap_info->body;
> + bp = &(ap_info->body[0]);
> bsize = ap_info->body_size;
> offset = 0;
>
> --
> 2.11.0
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@xxxxxxxxxxxxxxxx.
> To post to this group, send email to outreachy-kernel@xxxxxxxxxxxxxxxx.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20170226172741.GA20524%40arushi-HP-Pavilion-Notebook.
> For more options, visit https://groups.google.com/d/optout.
>
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
