On Fri, Feb 17, 2017 at 06:47:39PM +0900, Chetan Sethi wrote:
> This is 02nd patch to file ks_wlan.h file fixing error of enclosing
> complex macro value in parentheses
No need to have the "This is the XXX patch..." in the changelog text,
you don't see that in any other commit logs, right?
>
> Signed-off-by: Chetan Sethi <cpsethi369@xxxxxxxxx>
> ---
> v2:
> - split multiple changes across different patches
> v3:
> - mentioned patch revision in subject
> - incorporated review comment of correct indentation for do statement
>
> drivers/staging/ks7010/ks_wlan.h | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/ks7010/ks_wlan.h b/drivers/staging/ks7010/ks_wlan.h
> index 668202d..33d6b28 100644
> --- a/drivers/staging/ks7010/ks_wlan.h
> +++ b/drivers/staging/ks7010/ks_wlan.h
> @@ -36,8 +36,10 @@
>
> #ifdef KS_WLAN_DEBUG
> #define DPRINTK(n, fmt, args...) \
> - if (KS_WLAN_DEBUG > (n)) \
> - printk(KERN_NOTICE "%s: "fmt, __FUNCTION__, ## args)
> + do { \
Always run checkpatch on your patches so you don't get a grumpy
maintainer telling you to run your patches through checkpatch!
Please fix up all 3 of these and resend.
thanks,
greg k-h
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
