[PATCH 0/3] Fix checkpatch warnings

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Checkpatch emits various warnings. We can fix CONST_STRUCT trivially.
MULTILINE_DEREFERENCE warnings can be fixed but in most cases the fix
introduces line over 80 warnings.

Quote Documentation/process/coding-style.rst: "Statements longer than
80 columns will be broken into sensible chunks, unless exceeding 80
columns significantly increases readability and does not hide 
information"

Exceeding the 80 columns limit helps readabilty when it means we
don't have to break apart dereferences.

Remove line breaks from the middle of struct variable member
dereferences. Introduce new line over 80 checkpatch warnings.

Tobin C. Harding (3):
  staging: comedi: Fix checkpatch CONST_STRUCT
  staging: comedi: Remove level of indentation
  staging: comedi: Fix checkpatch MULTILINE_DEREFERENCE

 drivers/staging/comedi/drivers/addi_apci_3501.c  |  2 +-
 drivers/staging/comedi/drivers/adl_pci9118.c     |  3 +--
 drivers/staging/comedi/drivers/cb_pcidas64.c     | 29 +++++++++---------------
 drivers/staging/comedi/drivers/dt3000.c          |  3 +--
 drivers/staging/comedi/drivers/jr3_pci.c         |  3 +--
 drivers/staging/comedi/drivers/ni_atmio.c        |  4 ++--
 drivers/staging/comedi/drivers/ni_labpc_common.c |  3 +--
 drivers/staging/comedi/drivers/ni_mio_common.c   |  3 +--
 drivers/staging/comedi/drivers/rtd520.c          |  3 +--
 drivers/staging/comedi/drivers/s626.c            | 11 ++++-----
 10 files changed, 24 insertions(+), 40 deletions(-)

-- 
2.7.4

_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel



[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux