On Mon, Feb 20, 2017 at 05:44:50PM +0000, Valentin Huebner wrote: > Fixes a 'macro with flow control statement' checkpatch code style > error by removing the board_staging() macro and replacing its two > calls checkpatch is wrong here, you are now adding more lines than you remove: > Signed-off-by: Valentin Hübner <valentin.huebner@xxxxxxxxx> > --- > drivers/staging/board/armadillo800eva.c | 10 +++++++++- > drivers/staging/board/board.h | 11 ----------- > drivers/staging/board/kzm9d.c | 10 +++++++++- > 3 files changed, 18 insertions(+), 13 deletions(-) See? There's nothing wrong with the macro as-is, it's like many other macros we have for module init sequences. checkpatch is just a hint, you still have to use your brain :) sorry, greg k-h _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
