On Sun, 19 Feb 2017, Joe Perches wrote: > On Sun, 2017-02-19 at 23:56 +0530, Arushi Singhal wrote: > > Unnecessary parentheses should be avoided as reported by checkpatch.pl. > > Remove unnecessary parentheses, as reported by checkpatch as are nicer > > to read.For example:- > > It's often nicer to read if &(foo[0]) is converted to foo like: > > memcpy(&(ap->bssid[0]), &(ap_info->bssid[0]), ETH_ALEN); > > memcpy(ap->bssid, ap_info->bssid, ETH_ALEN); > [] > > diff --git a/drivers/staging/ks7010/ks_hostif.c b/drivers/staging/ks7010/ks_hostif.c > [] > > @@ -212,7 +212,7 @@ int get_ap_information(struct ks_wlan_private *priv, struct ap_info_t *ap_info, > > memset(ap, 0, sizeof(struct local_ap_t)); > > > > /* bssid */ > > - memcpy(&(ap->bssid[0]), &(ap_info->bssid[0]), ETH_ALEN); > > + memcpy(&ap->bssid[0], &ap_info->bssid[0], ETH_ALEN); > > This code doesn't match the suggested style of > your commit message. Is what is suggested in the commit message correct? That is, is the 0th element of an array always at the same address as a pointer to the array itself? Probably just paramoid... julia > > -- > You received this message because you are subscribed to the Google Groups "outreachy-kernel" group. > To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@xxxxxxxxxxxxxxxx. > To post to this group, send email to outreachy-kernel@xxxxxxxxxxxxxxxx. > To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/1487529117.2198.36.camel%40perches.com. > For more options, visit https://groups.google.com/d/optout. > _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
