On Sat, 18 Feb 2017, Arushi Singhal wrote: > function definition argument 'struct vb_device_info *' and 'unsigned > long' should also have an identifier name. This could be a bit more clear as "Add variable names to function prototype parameter list." > > Signed-off-by: Arushi Singhal <arushisinghal19971997@xxxxxxxxx> > --- > drivers/staging/xgifb/vb_init.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/xgifb/vb_init.h b/drivers/staging/xgifb/vb_init.h > index 500cabe41a3c..e4929314d33e 100644 > --- a/drivers/staging/xgifb/vb_init.h > +++ b/drivers/staging/xgifb/vb_init.h > @@ -1,6 +1,6 @@ > #ifndef _VBINIT_ > #define _VBINIT_ > unsigned char XGIInitNew(struct pci_dev *pdev); > -void XGIRegInit(struct vb_device_info *, unsigned long); > +void XGIRegInit(struct vb_device_info *pVBInfo, unsigned long BaseAddr); Actually, you should use the same names as found in the definition of the function, which seem to be: void XGIRegInit(struct vb_device_info *XGI_Pr, unsigned long BaseAddr) julia > #endif > > -- > 2.11.0 > > -- > You received this message because you are subscribed to the Google Groups "outreachy-kernel" group. > To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@xxxxxxxxxxxxxxxx. > To post to this group, send email to outreachy-kernel@xxxxxxxxxxxxxxxx. > To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20170218132356.GA4907%40arushi-HP-Pavilion-Notebook. > For more options, visit https://groups.google.com/d/optout. > _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
