Re: [PATCH 2/6] staging: ks7010: fix coding style issue of enclosing complex macro value in parentheses

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi, Chetan,

On Fri, Feb 17, 2017 at 02:51:11PM +0900, chetan wrote:
Is this fix really necessary?
This way of fixing is seen across multiple places in the kernel, so it
seems standard way of handling these kind of errors from checkpatch.

That's fair. I suppose the correct way to go about it would be
submitting a patch for checkpatch to remove the error in this case and
see how it's received, but I'm not confident enough in Perl to do
unfortunately.

On that note though, if it is going to be added I think it would make
sense to get the indentation correct with the `do {`:
Sure, I will update and resend v2 version of all the patches.

Sounds like a plan. When you resend them you should Cc it to the Linux
Kernel Mailing List at linux-kernel@xxxxxxxxxxxxxxx, I just noticed
these last emails weren't sent there.

Thanks,
Matthew Kilgore
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel



[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux