On 09/02/17 01:54, Brian Masney wrote: > The sysfs attribute in_proximity_sampling_frequency_available currently > shows the values 1 3 5 10 13 20 83 100. These values are supposed to > correspond to the sleep values 800 400 200 100 75 50 12 0 (all in ms). > When passing in a sampling frequency of 3, it actually uses a sleep > time of 200ms instead of the expected 400ms value. This patch changes > the 3 supported sampling frequency to 2 so that the proximity sleep > time of 400ms can be used. > > Signed-off-by: Brian Masney <masneyb@xxxxxxxxxxxxx> Given there is no real difficulty in supporting fixed point numbers, could we move this over to: 1, 2.5, 5 etc Will clearly require more changes than you have with the fixup here, but would represent what is going on more accurately for minimal cost. Jonathan > --- > drivers/staging/iio/light/isl29028.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/iio/light/isl29028.c b/drivers/staging/iio/light/isl29028.c > index 177dced..b63fdf70 100644 > --- a/drivers/staging/iio/light/isl29028.c > +++ b/drivers/staging/iio/light/isl29028.c > @@ -471,7 +471,7 @@ static int isl29028_read_raw(struct iio_dev *indio_dev, > } > > static IIO_CONST_ATTR(in_proximity_sampling_frequency_available, > - "1 3 5 10 13 20 83 100"); > + "1 2 5 10 13 20 83 100"); > static IIO_CONST_ATTR(in_illuminance_scale_available, "125 2000"); > > #define ISL29028_CONST_ATTR(name) (&iio_const_attr_##name.dev_attr.attr) > _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
