On 09/02/2017 11:04, Greg KH wrote:
On Thu, Feb 09, 2017 at 01:53:56AM +0530, Karthik Nayak wrote:
This patch fixes the following sparse error:
drivers/staging/comedi/drivers//ni_pcimio.c:1229:32: warning: incorrect type in assignment (different base types)
drivers/staging/comedi/drivers//ni_pcimio.c:1229:32: expected restricted __be32 [usertype] serial_number
drivers/staging/comedi/drivers//ni_pcimio.c:1229:32: got unsigned int
This is done by removing the whole code block, since the variable
'serial_number' is only assigned but never used.
Helped-by: Ian Abbott <abbotti@xxxxxxxxx>
There's no such tag, sorry :(
And does this obsolete all of your other ones? Please make it obvious
what I am supposed to do here.
I've now dropped all of these patches from my queue. please resend the
proper one.
thanks,
greg k-h
To add to that, I think the emphasis of the patch title and description
should now be on the removal of serial_number, with fixing the sparse
error as a useful side-effect/inspiration. The patch title should also
mention ni_pcimio.
Thanks,
Ian.
--
-=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@xxxxxxxxx> )=-
-=( Web: http://www.mev.co.uk/ )=-
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
