Hi all There is a "false positive" error reported by checkpatch.pl: ERROR: Use 4 digit octal (0777) not decimal permissions #272: FILE: drivers/staging/iio/meter/ade7759.c:272: +static IIO_DEV_ATTR_CH_OFF(1, S_IWUSR | S_IRUGO, + ade7759_read_8bit, + ade7759_write_8bit, + ADE7759_CH1OS); ERROR: Use 4 digit octal (0777) not decimal permissions #276: FILE: drivers/staging/iio/meter/ade7759.c:276: +static IIO_DEV_ATTR_CH_OFF(2, S_IWUSR | S_IRUGO, + ade7759_read_8bit, + ade7759_write_8bit, + ADE7759_CH2OS); The same for the file drivers/staging/iio/meter/ade7753.c. We can see that this macro is matched by the pattern "IIO_DEV_ATTR_[A-Z_]+" from @mode_permission_funcs in checkpatch.pl. My question is: how this should be fixed? >From what I can say, it's a false positive so the correct way to fix it is to change the matching pattern: "IIO_DEV_ATTR_(?!CH_OFF)[A-Z_]+". Or maybe the fix should be done in iio code - argument position inside this macro? -- Slawomir Stepien _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
