Em Sat, 3 Dec 2016 15:14:26 +0530 Tabrez khan <khan.tabrez21@xxxxxxxxx> escreveu: > Add parentheses around variable x for the readability purpose. > > This warning was found using checkpatch.pl. > > Signed-off-by: Tabrez khan <khan.tabrez21@xxxxxxxxx> > --- > drivers/staging/media/bcm2048/radio-bcm2048.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/media/bcm2048/radio-bcm2048.c b/drivers/staging/media/bcm2048/radio-bcm2048.c > index 4d9bd02..2f28dd0 100644 > --- a/drivers/staging/media/bcm2048/radio-bcm2048.c > +++ b/drivers/staging/media/bcm2048/radio-bcm2048.c > @@ -185,7 +185,7 @@ > #define v4l2_to_dev(f) ((f * BCM2048_FREQV4L2_MULTI) / BCM2048_FREQDEV_UNIT) > > #define msb(x) ((u8)((u16)x >> 8)) > -#define lsb(x) ((u8)((u16)x & 0x00FF)) > +#define lsb(x) ((u8)((u16)(x) & 0x00FF)) If you're willing to do that, you should do on all macros. Also, plese remove the extra space before the hexa value. > #define compose_u16(msb, lsb) (((u16)msb << 8) | lsb) > > #define BCM2048_DEFAULT_POWERING_DELAY 20 Thanks, Mauro _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
