On Thu, 2017-02-02 at 08:06 +0200, Martin Karamihov wrote: > On 02/01/2017 08:11 PM, Joe Perches wrote: > > ...and clarifying the code for a > > human reader is much more important than making a > > file not have any checkpatch warnings. > > I agree. I respect the developers' own coding style and believe that > some things (>80 characters long lines, name conventions, etc) should be > fixed by themselves (if they want to do that). I selected several TODOs > with requests for code cleanups and chose a fix in attempt to accomplish > my task with minimal inconvenience for the maintainers. I failed in my > first attempts breaking some basic rules, sorry about that. No, not at all. You did fine for a basic checkpatch cleanup. I just wanted to tell you to think beyond checkpatch. cheers, Joe _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
