From: David Binder <david.binder@xxxxxxxxxx> Clarifies why the pointer returned from visorbus_get_device_by_id() in bus_destroy() is validated. The check is performed in order to be extra careful, for the sake of added security, that the s-Par backend is providing us with a valid bus/device pair. Signed-off-by: David Binder <david.binder@xxxxxxxxxx> Signed-off-by: David Kershner <david.kershner@xxxxxxxxxx> Reported-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> --- drivers/staging/unisys/visorbus/visorchipset.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/unisys/visorbus/visorchipset.c b/drivers/staging/unisys/visorbus/visorchipset.c index c90ea6a..2d1b226 100644 --- a/drivers/staging/unisys/visorbus/visorchipset.c +++ b/drivers/staging/unisys/visorbus/visorchipset.c @@ -755,6 +755,7 @@ bus_destroy(struct controlvm_message *inmsg) int err; bus_info = visorbus_get_device_by_id(bus_no, BUS_ROOT_DEVICE, NULL); + /* Validate that s-Par backend gave a good bus */ if (!bus_info) { err = -ENODEV; goto err_respond; -- git-series 0.9.1 _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel