On 01/31/2017 05:42 AM, Russell King - ARM Linux wrote:
On Fri, Jan 20, 2017 at 03:38:28PM +0100, Hans Verkuil wrote:
Should be set to something like 'platform:imx-media-camif'. v4l2-compliance
should complain about this.
... and more.
Right, in version 3 that you are working with, no v4l2-compliance fixes were
in yet. A lot of the compliance errors are fixed, please look in latest
branch
imx-media-staging-md-wip at git@xxxxxxxxxx:slongerbeam/mediatree.git.
<snip>
Total: 39, Succeeded: 33, Failed: 6, Warnings: 0
Not all of these may be a result of Steve's code - this is running against
my gradually modified version to support bayer formats (which seems to be
the cause of the v4l2-test-formats.cpp failure... for some reason the
driver isn't enumerating all the formats.)
And that reason is the way that the formats are enumerated:
static int camif_enum_fmt_vid_cap(struct file *file, void *fh,
struct v4l2_fmtdesc *f)
{
const struct imx_media_pixfmt *cc;
u32 code;
int ret;
ret = imx_media_enum_format(&code, f->index, true, true);
if (ret)
return ret;
cc = imx_media_find_format(0, code, true, true);
if (!cc)
return -EINVAL;
When imx_media_enum_format() hits this entry in the table:
}, {
.fourcc = V4L2_PIX_FMT_BGR24,
.cs = IPUV3_COLORSPACE_RGB,
.bpp = 24,
}, {
becaues there's no .codes defined:
int imx_media_enum_format(u32 *code, u32 index, bool allow_rgb,
bool allow_planar)
{
...
*code = fmt->codes[0];
return 0;
}
So, we end up calling imx_media_find_format(0, 0, true, true), which
fails, returning NULL. That causes camif_enum_fmt_vid_cap() to
return -EINVAL.
So everything past this entry is unable to be enumerated.
I think this is a really round-about way of enumerating the pixel
formats when there are soo many entries in the table which have no
media bus code - there's absolutely no way that any of those entries
can ever be enumerated in this fashion, so they might as well not be
in the table...
That's my present solution to this problem, to #if 0 out all the
entries without any .codes field. I think the real answer is that
this needs a _separate_ function to enumerate the pixel formats for
camif_enum_fmt_vid_cap(). However, there may be other issues lurking
that I've not yet found (still trying to get this code to work...)
I believe this has been fixed in imx-media-staging-md-wip as well,
see imx-media-capture.c:capture_enum_fmt_vid_cap()
Camif subdev is gone, replaced with a set of exported functions
that allow attaching a capture device (and v4l2 interface) to a
calling subdev's output pad. See imx-media-capture.c.
The subdev's capture device interface is the only subdev that
can request a planar format from imx_media_enum_format().
All the others now (the non-device node pads), request only RGB
or packed YUV, or the IPU internal formats for IPU internal connections,
and these are the first entries in the table. The planar formats all are at
the end, which can only be enumerated by the capture device interfaces.
Steve
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
