Re: [PATCH v2] Fixes: 7ad82572348c ("staging:wlan-ng:Fix sparse warning")

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Jan 30, 2017 at 08:07:25PM -0800, Igor Pylypiv wrote:
> Conversion macros le16_to_cpu was removed and that caused new sparse warning
> 
> sparse output:
> drivers/staging/wlan-ng/p80211netdev.c:241:44: warning: incorrect type in argument 2 (different base types)
> drivers/staging/wlan-ng/p80211netdev.c:241:44:    expected unsigned short [unsigned] [usertype] fc
> drivers/staging/wlan-ng/p80211netdev.c:241:44:    got restricted __le16 [usertype] fc
> 
> Signed-off-by: Igor Pylypiv <igor.pylypiv@xxxxxxxxx>
> ---
>  drivers/staging/wlan-ng/p80211netdev.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

"Fixes:" goes down here in the area where Signed-off-by: is, not in the
subject line.  Please fix up the subject to be "correct" and match up
the way that other commits for this driver looks like and resend.

thanks,

greg k-h
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel



[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux