On 01/30/2017 03:29 PM, Russell King - ARM Linux wrote:
On Fri, Jan 06, 2017 at 06:11:40PM -0800, Steve Longerbeam wrote:
+config IMX_OV5640_MIPI
+ tristate "OmniVision OV5640 MIPI CSI-2 camera support"
+ depends on GPIOLIB && VIDEO_IMX_CAMERA
+ select IMX_MIPI_CSI2
+ default y
Why is this defaulting to y? New drivers should not default to enabled
unless they are replacing some already pre-existing functionality.
Ditto for the other camera driver.
The ov564x sensors are required for the SabreSD and SabreLite/Nitrogen
reference boards (if VIDEO_IMX_CAMERA is enabled that is). But they're not
required for other platforms, so you're right I shouldn't have defaulted
these
to yes. Fixed.
Steve
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
