Re: [PATCH] staging: bcm2835-audio: Strengthen build dependencies

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Michael Zoran <mzoran@xxxxxxxxxxxx> writes:

> This driver makes no sense outside of ARM or ARM64.
> Add an explicit build dependency on:
> (ARM || ARM64 || COMPILE_TEST)
>
> Also set the default build to n
>
> Signed-off-by: Michael Zoran <mzoran@xxxxxxxxxxxx>
> ---
>  drivers/staging/bcm2835-audio/Kconfig | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/drivers/staging/bcm2835-audio/Kconfig b/drivers/staging/bcm2835-audio/Kconfig
> index 32a2ff9ef9b2..840faa21f665 100644
> --- a/drivers/staging/bcm2835-audio/Kconfig
> +++ b/drivers/staging/bcm2835-audio/Kconfig
> @@ -1,6 +1,8 @@
>  config SND_BCM2835
>          tristate "BCM2835 ALSA driver"
>          depends on ARCH_BCM2835 && BCM2835_VCHIQ && SND
> +	depends on (ARM || ARM64 || COMPILE_TEST)
> +	default n
>          select SND_PCM
>          help
>            Say Y or M if you want to support BCM2835 Alsa pcm card driver

We've already got a DEPENDS on ARCH_BCM2835, how would that be present
without one of those three being set?

Attachment: signature.asc
Description: PGP signature

_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux