Artur Lorincz schrieb am 30.01.2017 um 11:10: > Replaced the symbolic permission references S_IRUGO and S_IWUSR with their > octal counterparts. Hi Artur, patches concerning IIO should be sent to the linux-iio mailing list, and former maintainers of the file should be CC'ed. Now, regarding your patch, I am not convinced that this is an improvement. Those symbols are usually used to improve readability, which is not given with more or less magical numbers. Thanks, Hartmut > > Signed-off-by: Artur Lorincz <larturus@xxxxxxxxx> > --- > drivers/staging/iio/adc/ad7192.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/staging/iio/adc/ad7192.c b/drivers/staging/iio/adc/ad7192.c > index 1fb68c0..4fc8588 100644 > --- a/drivers/staging/iio/adc/ad7192.c > +++ b/drivers/staging/iio/adc/ad7192.c > @@ -342,9 +342,9 @@ static int ad7192_setup(struct ad7192_state *st, > > static IIO_DEVICE_ATTR_NAMED(in_v_m_v_scale_available, > in_voltage-voltage_scale_available, > - S_IRUGO, ad7192_show_scale_available, NULL, 0); > + 0444, ad7192_show_scale_available, NULL, 0); > > -static IIO_DEVICE_ATTR(in_voltage_scale_available, S_IRUGO, > +static IIO_DEVICE_ATTR(in_voltage_scale_available, 0444, > ad7192_show_scale_available, NULL, 0); > > static ssize_t ad7192_show_ac_excitation(struct device *dev, > @@ -412,11 +412,11 @@ static ssize_t ad7192_set(struct device *dev, > return ret ? ret : len; > } > > -static IIO_DEVICE_ATTR(bridge_switch_en, S_IRUGO | S_IWUSR, > +static IIO_DEVICE_ATTR(bridge_switch_en, 0644, > ad7192_show_bridge_switch, ad7192_set, > AD7192_REG_GPOCON); > > -static IIO_DEVICE_ATTR(ac_excitation_en, S_IRUGO | S_IWUSR, > +static IIO_DEVICE_ATTR(ac_excitation_en, 0644, > ad7192_show_ac_excitation, ad7192_set, > AD7192_REG_MODE); > > -- > 1.9.1 > >
Attachment:
0xFAC89148.asc
Description: application/pgp-keys
Attachment:
signature.asc
Description: OpenPGP digital signature
_______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
