On Sat, 2017-01-28 at 19:05 +1300, Derek Robson wrote: > A style fix across whole driver. > changed permissions to octal style, found using checkpatch [] > diff --git a/drivers/staging/speakup/main.c b/drivers/staging/speakup/main.c [] > @@ -58,8 +58,8 @@ MODULE_LICENSE("GPL"); > MODULE_VERSION(SPEAKUP_VERSION); > > char *synth_name; > -module_param_named(synth, synth_name, charp, S_IRUGO); > -module_param_named(quiet, spk_quiet_boot, bool, S_IRUGO); > +module_param_named(synth, synth_name, charp, 0444 ); > +module_param_named(quiet, spk_quiet_boot, bool, 0444 ); Please don't add spaces before the close parenthesis. _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel