On 25.01.2017 14:39, Greg Kroah-Hartman wrote:
On Wed, Jan 25, 2017 at 02:24:22PM +0200, Dragos Tarcatu wrote:
Fixed the following checkpatch.pl errors in fb_pcd8544.c:
ERROR: Use 4 digit octal (0777) not decimal permissions
+module_param(tc, uint, 0);
ERROR: Use 4 digit octal (0777) not decimal permissions
+module_param(bs, uint, 0);
Also made the two module parameters readable from sysfs.
Why?
That's a change in functionality, and should always be done in a
separate patch. Along with a bunch of justification for it...
thanks,
greg k-h
There are several files in fbtft which exhibit these checkpatch errors.
I was simply trying to get rid of some of them, and when I went through
this month list archive I got into some questions like 'how about having
these readable?' ...
Anyway, I can see why having this change along with the checkpatch fixes
is wrong.
Somehow I also missed a patch just from the other day which fixes all of
these in one shot ...
Dragos
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
