The vchi_msg_queue function which is used by other drivers to queue a message is difficult to understand and overly generic. Make the function static and remove it from the exported symbols. Signed-off-by: Michael Zoran <mzoran@xxxxxxxxxxxx> --- drivers/staging/vc04_services/interface/vchi/vchi.h | 8 -------- drivers/staging/vc04_services/interface/vchiq_arm/vchiq_shim.c | 2 +- 2 files changed, 1 insertion(+), 9 deletions(-) diff --git a/drivers/staging/vc04_services/interface/vchi/vchi.h b/drivers/staging/vc04_services/interface/vchi/vchi.h index 1a401f04d03f..addb7b00b688 100644 --- a/drivers/staging/vc04_services/interface/vchi/vchi.h +++ b/drivers/staging/vc04_services/interface/vchi/vchi.h @@ -219,14 +219,6 @@ extern int32_t vchi_service_set_option( const VCHI_SERVICE_HANDLE_T handle, VCHI_SERVICE_OPTION_T option, int value); -// Routine to send a message across a service -extern int32_t - vchi_msg_queue(VCHI_SERVICE_HANDLE_T handle, - ssize_t (*copy_callback)(void *context, void *dest, - size_t offset, size_t maxsize), - void *context, - uint32_t data_size); - /* Routine to send a message from kernel memory across a service */ extern int vchi_queue_kernel_message(VCHI_SERVICE_HANDLE_T handle, diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_shim.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_shim.c index 8987c4ad3653..aec2a0c40c44 100644 --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_shim.c +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_shim.c @@ -158,6 +158,7 @@ EXPORT_SYMBOL(vchi_msg_remove); * Returns: int32_t - success == 0 * ***********************************************************/ +static int32_t vchi_msg_queue(VCHI_SERVICE_HANDLE_T handle, ssize_t (*copy_callback)(void *context, void *dest, size_t offset, size_t maxsize), @@ -186,7 +187,6 @@ int32_t vchi_msg_queue(VCHI_SERVICE_HANDLE_T handle, return vchiq_status_to_vchi(status); } -EXPORT_SYMBOL(vchi_msg_queue); static ssize_t vchi_queue_kernel_message_callback(void *context, -- 2.11.0 _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
