On Mon, 2017-01-23 at 14:38 +0300, Dan Carpenter wrote: > I'm attaching how I would basically like to see patch 1/7 done. It's > not perfect, I did it as quickly as possible and haven't tested > anything. I would normally be more careful if I were sending this > for > inclusion so there are no sign offs etc. Thanks, Dan. I appreciate the clarify on what you are looking for. Sounds like if I go that route it's going to take some time. I'm thinking that if I do this I should deal with one ioctl cleanup per series instead of aiming for the goal of getting compat to work. What's your opinion of building the compat_ioctl function on top of the existing code? Using the internal compat functions to build a 64 bit version of the data on the user mode stack? With that approach none of the existing code would need to be touched although the end result wouldn't be as nice or maintainable. _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel