Re: [PATCH v3 4/4] staging: greybus: loopback: convert to use msecs internally

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Jan 04, 2017 at 12:11:21AM +0000, Bryan O'Donoghue wrote:
> The API presented by operation.h expects milliseconds to be passed in.
> This patch drops the conversion from user-input microseconds-to-jiffies and
> from jiffies-to-milliseconds and instead converts directly from
> microseconds-to-milliseconds. The new minimum timeout will be one
> millisecond as opposed to one jiffy.

You also reduced the maximum in a similar way (1 ms <= 1 jiffie). You
could mention that here as well.

> Signed-off-by: Bryan O'Donoghue <pure.logic@xxxxxxxxxxxxxxxxx>

Reviewed-by: Johan Hovold <johan@xxxxxxxxxx>

> ---
>  drivers/staging/greybus/loopback.c | 16 ++++++++--------
>  1 file changed, 8 insertions(+), 8 deletions(-)
 
> -/* Min/max values in jiffies */
> +/* Min/max values in milliseconds */
>  #define GB_LOOPBACK_TIMEOUT_MIN				1
>  #define GB_LOOPBACK_TIMEOUT_MAX				10000

Thanks,
Johan
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel



[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux