On 17/01/17 09:24, Brian Masney wrote:
> If the call to isl29028_chip_init_and_power_on() in isl29028_probe()
> fails, then isl29028_probe() will log an error message. All of the
> error paths in that call path already have error logging in place. This
> patch removes the unnecessary logging.
>
> Signed-off-by: Brian Masney <masneyb@xxxxxxxxxxxxx>
applied.
> ---
> drivers/staging/iio/light/isl29028.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/staging/iio/light/isl29028.c b/drivers/staging/iio/light/isl29028.c
> index cffecf9..be1fc4a 100644
> --- a/drivers/staging/iio/light/isl29028.c
> +++ b/drivers/staging/iio/light/isl29028.c
> @@ -528,10 +528,8 @@ static int isl29028_probe(struct i2c_client *client,
> }
>
> ret = isl29028_chip_init_and_power_on(chip);
> - if (ret < 0) {
> - dev_err(&client->dev, "chip initialization failed: %d\n", ret);
> + if (ret < 0)
> return ret;
> - }
>
> indio_dev->info = &isl29028_info;
> indio_dev->channels = isl29028_channels;
>
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
