Hi Steve, Philipp, On 01/07/2017 03:11 AM, Steve Longerbeam wrote: > In version 3: > > Changes suggested by Rob Herring <robh@xxxxxxxxxx>: > > - prepended FIM node properties with vendor prefix "fsl,". > > - make mipi csi-2 receiver compatible string SoC specific: > "fsl,imx6-mipi-csi2" instead of "fsl,imx-mipi-csi2". > > - redundant "_clk" removed from mipi csi-2 receiver clock-names property. > > - removed board-specific info from the media driver binding doc. These > were all related to sensor bindings, which already are (adv7180) > or will be (ov564x) covered in separate binding docs. All reference > board info not related to DT bindings has been moved to > Documentation/media/v4l-drivers/imx.rst. > > - removed "_mipi" from the OV5640 compatible string. > > Changes suggested by Vladimir Zapolskiy <vladimir_zapolskiy@xxxxxxxxxx>: > > Mostly cosmetic/non-functional changes which I won't list here, except > for the following: > > - spin_lock_irqsave() changed to spin_lock() in a couple interrupt handlers. > > - fixed some unnecessary of_node_put()'s in for_each_child_of_node() loops. > > - check/handle return code from required reg property of CSI port nodes. > > - check/handle return code from clk_prepare_enable(). > > Changes suggested by Fabio Estevam <festevam@xxxxxxxxx>: > > - switch to VGEN3 Analog Vdd supply assuming rev. C SabreSD boards. > > - finally got around to passing valid IOMUX pin config values to the > pin groups. > > Other changes: > > - removed the FIM properties that overrided the v4l2 FIM control defaults > values. This was left-over from a requirement of a customer and is not > necessary here. > > - The FIM must be explicitly enabled in the fim child node under the CSI > port nodes, using the status property. If not enabled, FIM v4l2 controls > will not appear in the video capture driver. > > - brought in additional media types patch from Philipp Zabel. Use new > MEDIA_ENT_F_VID_IF_BRIDGE in mipi csi-2 receiver subdev. > > - brought in latest platform generic video multiplexer subdevice driver > from Philipp Zabel (squashed with patch that uses new MEDIA_ENT_F_MUX). > > - removed imx-media-of.h, moved those prototypes into imx-media.h. Based on the discussion on the mailinglist it seems everyone agrees that this is the preferred driver, correct? There are a bunch of review comments, so I will wait for a v4. I plan to merge that staging driver unless there are major issues with it. I am not sure if I would merge those sensor drivers in staging, I'll have to take a closer look at those once v4 is posted. Regards, Hans _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel