On Thu, 2017-01-19 at 10:49 +0100, Greg Kroah-Hartman wrote: > On Tue, Jan 03, 2017 at 08:29:45PM +0200, Andy Shevchenko wrote: > > First of all, fbtft in current state doesn't allow to override GPIOs > > to be > > optional, like "reset" one. It might be a bug somewhere, but rather > > out of > > scope of this fix. > > > > Second, not all GPIOs available on the board would be SoC based, > > some of them > > might sit on I2C GPIO expanders, for example, on Intel > > Edison/Arduino, and thus > > any communication with them might sleep. > > > > Besides that using udelay() and mdelay() is kinda resource wasteful. > > > > Summarize all of the above, convert fbtft_reset() function to non- > > atomic > > variant by using gpio_set_value_cansleep(), usleep_range(), and > > msleep(). > > > > Reviewed-by: Noralf Trønnes <noralf@xxxxxxxxxxx> > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> > > Andy, this series came through with the charmap all corrupted and git > didn't like them at all. Can you fix up and resend? Strange. I used usual git send-email. Okay, just resent (as v4). -- Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> Intel Finland Oy _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
