Re: [PATCH v2 4/4] staging: greybus: audio: Ensure proper byte order

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Jan 17, 2017 at 11:22 PM, Mark Greer <mgreer@xxxxxxxxxxxxxxx> wrote:
> On Tue, Jan 17, 2017 at 08:19:30PM +0530, Vaibhav Agarwal wrote:
>> From: Vaibhav Agarwal <vaibhav.agarwal@xxxxxxxxxx>
>>
>> Proper byte order was completely disregarded for multi byte data shared
>> between AP and module (and APB1). Fix this.
>>
>> Signed-off-by: Vaibhav Agarwal <vaibhav.agarwal@xxxxxxxxxx>
>> ---
>
> Hi Vaibhav.
>
> I think you got them all except for this one in
> audio_topology.c:gbcodec_mixer_dapm_ctl_put():
>
>>>>     max = info->value.integer.max;  <<<
>         mask = (1 << fls(max)) - 1;
>         val = ucontrol->value.integer.value[0] & mask;
>         connect = !!val;

Oh Ok. I'll include this change in v3.

--
vaibhav
>
> Mark
> --
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel



[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux